Remove metadata casts to byte #3706
Conversation
These are incompatible with NEID and can cause problems with blocks whose metadata can go over 127.
RecursivePineapple
added
refactor
|
@RecursivePineapple Did you test this in full pack? There are probably changes needed in some other mods that add machines |
|
@serenibyss no I didn't, thanks for reminding me |
|
Hey @serenibyss, I tested this in the full pack and it didn't crash. I tried searching for any non-gt5u deps that would be broken by this but I couldn't find any, so I'm not sure what items or blocks I should test. I figure that it'd crash if there were any method signature incompatibilities. |
|
is this zeta safe to test ? @RecursivePineapple |
|
@Dream-Master I didn't run it on a gate base because I couldn't find a link for it, but I did test it in an SP world. It should be relatively low-risk since any linkage errors should show up during modpack start, but I'm not sure what the standards for zeta are. |
|
ok will add next update |
These are incompatible with NEID and cause problems with blocks whose metadata can go over 127.
This shouldn't have any side effects since nothing changed here relies on bit math.
I ran a quick sanity test on everything I touched to make sure I didn't break anything.
I didn't change some stuff related to ores & prospecting because I didn't want to create merge conflicts for my ore refactor PR, which already has those changes.
I'm sure I've missed something, but this should be most of the casts & byte params/returns. I used this regex to find these:
byte.*meta(case insensitive), then I fixed the syntax errors that resulted from the changes.